Some CI setups are much slower then the equipment used by Cargo itself #6596
Conversation
|
r? @dwijnand (rust_highfive has picked a reviewer for you, use r? to override) |
|
LGTM. I'm not sure if the lazy static is so necessary, and it's unfortunate to not be able to share the impl with the integration tests, but we can forward-fix these down the line. You need to import std::env though. r=me |
|
@bors: r=dwijnand |
|
📌 Commit 1c1383c has been approved by |
src/cargo/core/resolver/types.rs
Outdated
| // Some CI setups are much slower then the equipment used by Cargo itself. | ||
| // Architectures that do not have a modern processor, hardware emulation, ect. | ||
| // In the test code we have `slow_cpu_multiplier`, but that is not accessible here. | ||
| lazy_static::lazy_static! { |
There was a problem hiding this comment.
Instead of lazy_static, could this be stored as a field in ResolverProgress?
There was a problem hiding this comment.
Does that look better?
|
Just one minor nit, but otherwise r=me |
|
@bors r- |
|
@bors: r=dwijnand+alexcrichton |
|
📌 Commit 7332f67 has been approved by |
Some CI setups are much slower then the equipment used by Cargo itself This adds a "CARGO_TEST_SLOW_CPU_MULTIPLIER" that increases all the time outs used in the tests, and disables Proptest shrinking on non tty cases. Closes: #6491 CC: #6490, @infinity0
|
☀️ Test successful - checks-travis, status-appveyor |
This adds a "CARGO_TEST_SLOW_CPU_MULTIPLIER" that increases all the time outs used in the tests, and disables Proptest shrinking on non tty cases.
Closes: #6491
CC: #6490, @infinity0